Skip to content

Comments

gh-143331: Schedule to remove format "N" for Decimal#143372

Merged
hugovk merged 5 commits intopython:mainfrom
donbarbos:issue-143331
Jan 6, 2026
Merged

gh-143331: Schedule to remove format "N" for Decimal#143372
hugovk merged 5 commits intopython:mainfrom
donbarbos:issue-143331

Conversation

@donbarbos
Copy link
Contributor

@donbarbos donbarbos commented Jan 2, 2026 •
edited by github-actions bot
Loading

@donbarbos donbarbos requested a review from AA-Turner as a code owner January 2, 2026 20:09
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 2, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 2, 2026
Closed
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jan 2, 2026
sobolevn
sobolevn reviewed Jan 4, 2026
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also update Doc/whatsnew/3.15.rst to include 3.18.rst

@donbarbos
Copy link
Contributor Author

donbarbos commented Jan 4, 2026

Shouldn't this also be added to 3.13 and 3.14 whatsnew entries?

sobolevn
sobolevn reviewed Jan 4, 2026
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you updated 3.13 and 3.15, but not 3.14 :)

@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 5, 2026
@sobolevn sobolevn requested a review from hugovk January 5, 2026 10:29
@hugovk
Copy link
Member

hugovk commented Jan 5, 2026

For visibility, let's also mention the removal version in the deprecation warning:

cpython/Modules/_decimal/_decimal.c

Lines 3597 to 3598 in be0074f

if (PyErr_WarnEx(PyExc_DeprecationWarning,
"Format specifier 'N' is deprecated", 1) < 0) {

@hugovk hugovk merged commit dd750b3 into python:main Jan 6, 2026
46 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jan 6, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 6, 2026

Thanks @donbarbos for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Jan 6, 2026

Sorry, @donbarbos and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker dd750b348501247d458ea8d454213d4959a8f8b9 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Jan 6, 2026

Sorry, @donbarbos and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker dd750b348501247d458ea8d454213d4959a8f8b9 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2026

GH-143476 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 6, 2026
donbarbos added a commit to donbarbos/cpython that referenced this pull request Jan 6, 2026
@donbarbos
[3.14] pythongh-143331: Schedule to remove format "N" for Decimal (py…
cca7f38 
…thonGH-143372)

(cherry picked from commit dd750b3)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>
donbarbos added a commit to donbarbos/cpython that referenced this pull request Jan 6, 2026
@donbarbos
[3.13] pythongh-143331: Schedule to remove format "N" for Decimal (py…
e2b9e15 
…thonGH-143372)

(cherry picked from commit dd750b3)

Co-authored-by: Semyon Moroz <donbarbos@proton.me>
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2026

GH-143477 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 6, 2026
hugovk pushed a commit that referenced this pull request Jan 6, 2026
@donbarbos
[3.14] gh-143331: Schedule to remove format "N" for Decimal (GH-143372)…
8b72c3d 
… (#143476)

(cherry picked from commit dd750b3)
hugovk pushed a commit that referenced this pull request Jan 6, 2026
@donbarbos
[3.13] gh-143331: Schedule to remove format "N" for Decimal (GH-143372)…
97694de 
… (#143477)

(cherry picked from commit dd750b3)
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@donbarbos @thunder-coding
pythongh-143331: Schedule to remove format "N" for Decimal (python#14…
816fe7a 
…3372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@skirpichev skirpichev skirpichev approved these changes

@sobolevn sobolevn sobolevn approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@donbarbos @hugovk @skirpichev @sobolevn